Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize NameAndTypeResolution tests #3621

Closed
chriseth opened this issue Feb 28, 2018 · 0 comments
Closed

Standardize NameAndTypeResolution tests #3621

chriseth opened this issue Feb 28, 2018 · 0 comments

Comments

@chriseth
Copy link
Contributor

As part of #3486, we should standardise the NameAndTypeResolution tests so that their test expectations can be easily upgraded. This will be very important for the transition to version 0.5.0 since it requires many updates.

The idea would be to move each test into its own file which contains source code and the list of errors and warnings it generates.

We should also take this opportunity and create a new name for the test suite while gradually moving out the tests. It should probably be named something like SyntaxTests (and the EndToEndTests should be renamed SemanticsTests).

It is often beneficial to group similar tests. This can either be done by allowing multiple tests per file or by creating subdirectories for the test data.

The test runner should still use boost test because this allows us to benefit from its xml reporting output, but it should dynamically modify the test tree based on the files.

There should be a way to run the test which, for each failing test, interactively displays the test input, the multiset of expected errors and the multiset of actual errors and allows to either accept the changed expectations or not (and skip to the next failing test). This way to run the tests could be its own executable.

@chriseth chriseth closed this as completed Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant