Fix check_style.sh refactor #10862
Merged
Fix check_style.sh refactor #10862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
fix-wrong-script-path-in-check-style-sh
branch
2 times, most recently
from
db9a2e5 to
1afe24c
Compare
cameel
changed the title
- The script is actually in a subdirectory.
cameel
force-pushed
the
fix-wrong-script-path-in-check-style-sh
branch
from
cc6e422 to
922134d
Compare
cameel
force-pushed
the
fix-wrong-script-path-in-check-style-sh
branch
from
922134d to
cd4b667
Compare
|
It's now ready for review and the |
chriseth
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bugs introduced in #10797. Looks like I did not test it thoroughly enough.
Note: It's still a draft because I included a commit with intentional style error to make sure the script works this time. I'll remove it and mark as ready to review once I see that comments are getting posted correctly.It's ready now.