Use Bash arrays for argument lists in shell scripts #10877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DEBUGGER - There are ways to fix the warning properly but they're all less readable than this in my opinion.
cameel
force-pushed
the
bash-arrays-for-arg-variables
branch
from
37b0f80 to
cba6e68
Compare
Base automatically changed from
fix-quoting-and-whitespace-in-shell-scripts
to
develop
February 3, 2021 10:27
leonardoalt
reviewed
Feb 3, 2021
|
I think I can mark this as ready for review without extra manual testing because all the modified scripts in this PR do run in CI. |
hrkrshnn
approved these changes
Feb 4, 2021
| if [ -n "$log_directory" ] | ||
| then | ||
| if [ -n "$optimize" ] | ||
| then | ||
| log=--logger=JUNIT,error,$log_directory/opt_$vm.xml | ||
| log+=("--logger=JUNIT,error,$log_directory/opt_$vm.xml") |
There was a problem hiding this comment.
= should work here as well, right?
Just asking, doesn't need any changes.
There was a problem hiding this comment.
Sorry, for not getting back to this one earlier :)
Yeah, it would work and it would match the original code better but I think that += is more appropriate here. If log were initialized with a non-empty array, we'd likely want to add to it rather than ovewrite it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #10585.
This PR fixes shellcheck warnings about missing quotes in cases where they can contain spaces and are unquoted on purpose (to rely on Bash word splitting behavior). The solution is to use Bash arrays.