Silence remaining shellcheck warnings and remove ignore list #10879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
silence-remaining-shellcheck-warnings-and-remove-ignore-list
branch
2 times, most recently
from
480b218 to
5e61c10
Compare
cameel
force-pushed
the
shellcheck-fixes-part1
branch
from
1e5f0e5 to
f381a24
Compare
cameel
force-pushed
the
silence-remaining-shellcheck-warnings-and-remove-ignore-list
branch
from
5e61c10 to
0b057ed
Compare
cameel
force-pushed
the
shellcheck-fixes-part1
branch
from
f381a24 to
fa9b8c9
Compare
cameel
force-pushed
the
silence-remaining-shellcheck-warnings-and-remove-ignore-list
branch
2 times, most recently
from
de7baa3 to
9cb9a07
Compare
cameel
force-pushed
the
silence-remaining-shellcheck-warnings-and-remove-ignore-list
branch
from
9cb9a07 to
10dbb60
Compare
cameel
force-pushed
the
shellcheck-fixes-part1
branch
from
09c9591 to
cf94c3f
Compare
cameel
force-pushed
the
silence-remaining-shellcheck-warnings-and-remove-ignore-list
branch
from
10dbb60 to
3efc023
Compare
cameel
force-pushed
the
silence-remaining-shellcheck-warnings-and-remove-ignore-list
branch
from
3efc023 to
dd9bf82
Compare
|
I have just merged #10586 so I'm marking this as ready for review. |
ekpyron
previously approved these changes
Mar 15, 2021
… files on its own
…g or the problem is not worth fixing
cameel
force-pushed
the
silence-remaining-shellcheck-warnings-and-remove-ignore-list
branch
from
dd9bf82 to
b8979a9
Compare
|
Rebased on |
ekpyron
approved these changes
Mar 15, 2021
cameel
deleted the
silence-remaining-shellcheck-warnings-and-remove-ignore-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #10586. It will remain a draft until all PRs below are merged.It's ondevelopnow.This is the last batch and mostly just disables warnings where shellcheck is overzealous or doing it properly is not worth the extra effort.
It also removes the whole ignorelist mechanism from our scripts. I think that going forward it's better to add specific local ignores in scripts instead of having the whole script ignored.