Fix test builtins & add simple smoke test. #11304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
reviewed
Apr 23, 2021
test/libsolidity/SemanticTest.cpp
Outdated
|
|
||
| void SemanticTest::initializeBuiltins() | ||
| { | ||
| m_builtins["smoke_test"] = [](FunctionCall const&) -> std::optional<bytes> |
Collaborator
There was a problem hiding this comment.
Don't we typically use camel case for builtins?
Also, make sure there are no name clashes (unlikely but better safe than sorry :)).
Suggested change
| m_builtins["smoke_test"] = [](FunctionCall const&) -> std::optional<bytes> | |
| solAssert(m_builtins.count("smokeTest") == 0, ""); | |
| m_builtins["smokeTest"] = [](FunctionCall const&) -> std::optional<bytes> |
Contributor
There was a problem hiding this comment.
This is the first builtin to be added, but the assert is good to have, yes.
Collaborator
There was a problem hiding this comment.
Ah, good point. I thought that the existing "directives" were builtins but I see that it's a new thing.
aarlt
force-pushed
the
fix_test_builtins
branch
from
7b6184a to
4ab3cb6
Compare
aarlt
force-pushed
the
fix_test_builtins
branch
from
4ab3cb6 to
8239eaa
Compare
chriseth
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.