Allow basefee as Yul identifier for EVMVersion < london #11763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrkrshnn
force-pushed
the
basefee-hasOpcode
branch
3 times, most recently
from
3f9fb52 to
a8418ce
Compare
hrkrshnn
force-pushed
the
basefee-hasOpcode
branch
from
a8418ce to
0c8b612
Compare
ekpyron
previously approved these changes
Aug 9, 2021
hrkrshnn
force-pushed
the
default-evmversion-london
branch
4 times, most recently
from
f7794d0 to
87b486b
Compare
|
Will rebase this now. |
hrkrshnn
force-pushed
the
default-evmversion-london
branch
from
87b486b to
90183a6
Compare
hrkrshnn
force-pushed
the
basefee-hasOpcode
branch
from
0c8b612 to
abecad3
Compare
hrkrshnn
force-pushed
the
default-evmversion-london
branch
from
90183a6 to
7adfc27
Compare
hrkrshnn
force-pushed
the
basefee-hasOpcode
branch
from
abecad3 to
42757fa
Compare
hrkrshnn
force-pushed
the
default-evmversion-london
branch
from
7adfc27 to
79733fc
Compare
hrkrshnn
force-pushed
the
basefee-hasOpcode
branch
from
42757fa to
7bb71f2
Compare
ekpyron
reviewed
Aug 11, 2021
| assembly { | ||
| ret := basefee() | ||
| } | ||
| } | ||
| } | ||
| // ==== | ||
| // EVMVersion: =berlin |
There was a problem hiding this comment.
Starting from here you can then make it <=, though :-).
There was a problem hiding this comment.
I'll change this once everything gets merged :)
There was a problem hiding this comment.
Actually, will do this now.
ekpyron
reviewed
Aug 11, 2021
| } | ||
| // ==== | ||
| // compileViaYul: also | ||
| // EVMVersion: =berlin |
There was a problem hiding this comment.
If you change the other one to <= you can do this one as well.
This was done to prevent basefee from being a breaking change. This change will be removed in 0.9.0. TODO revert this commit in breaking.
hrkrshnn
force-pushed
the
basefee-hasOpcode
branch
from
7bb71f2 to
8a61222
Compare
Also added basefee to `EVMVersion::hasOpcode(...)`
hrkrshnn
force-pushed
the
basefee-hasOpcode
branch
from
8a61222 to
892700d
Compare
ekpyron
approved these changes
Aug 11, 2021
This was referenced Dec 20, 2023
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done to prevent basefee from being a breaking change. This change will be removed in 0.9.0.
TODO revert this commit in breaking.