LineColumn handling for CharStream.

[chriseth]

No description provided.

[christianparpart]

I think you've done this because Boost.Test makes use of it for failure outputs?

[cameel]

I think that adding stuff to std is undefined behavior though, which is why I've usually been doing it this way instead:

solidity/test/solc/CommandLineInterface.cpp

Lines 50 to 108 in a7d89a9

	namespace
	{
	ostream& operator<<(ostream& _out, vector<ImportRemapper::Remapping> const& _remappings)
	{
	static auto remappingToString = [](auto const& _remapping)
	{
	return _remapping.context + ":" + _remapping.prefix + "=" + _remapping.target;
	};
	_out << "[" << joinHumanReadable(_remappings | ranges::views::transform(remappingToString)) << "]";
	return _out;
	}
	ostream& operator<<(ostream& _out, map<string, string> const& _map)
	{
	_out << "{" << endl;
	for (auto const& [key, value]: _map)
	_out << "" << key << ": " << value << "," << endl;
	_out << "}";
	return _out;
	}
	ostream& operator<<(ostream& _out, PathSet const& _paths)
	{
	static auto pathString = [](auto const& _path) { return _path.string(); };
	_out << "{" << joinHumanReadable(_paths | ranges::views::transform(pathString)) << "}";
	return _out;
	}
	} // namespace
	namespace boost::test_tools::tt_detail
	{
	// Boost won't find the << operator unless we put it in the std namespace which is illegal.
	// The recommended solution is to overload print_log_value<> struct and make it use our operator.
	template<>
	struct print_log_value<vector<ImportRemapper::Remapping>>
	{
	void operator()(std::ostream& _out, vector<ImportRemapper::Remapping> const& _value) { ::operator<<(_out, _value); }
	};
	template<>
	struct print_log_value<map<string, string>>
	{
	void operator()(std::ostream& _out, map<string, string> const& _value) { ::operator<<(_out, _value); }
	};
	template<>
	struct print_log_value<PathSet>
	{
	void operator()(std::ostream& _out, PathSet const& _value) { ::operator<<(_out, _value); }
	};
	} // namespace boost::test_tools::tt_detail

[cameel]

Also, it would be nice to have this definition in test/Common.h or some file it includes so that you don't have to define it every time locally.

[christianparpart]

anonymous namespace is not visible across compilation units though. I think ostream& operator<<(ostream&, T) should simply be in the same namespace as T to be found by ADL (argument dependent lookup), isn't it?

[cameel]

Looks fine in general but I just realized that we completely ignore CRLF. Can we actually do that?

[cameel]

Given that we do not indent namespaces, I think it's a nice convention to comment where they end:

Suggested change

	}
	} //namespace std

Also, some whitespace after opening and before ending brace would be nice for readability.