Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External test for Bleeps #12531

Merged
merged 1 commit into from
Jan 17, 2022
Merged

External test for Bleeps #12531

merged 1 commit into from
Jan 17, 2022

Conversation

cameel
Copy link
Member

@cameel cameel commented Jan 14, 2022

Part of #5956.
Depends on #12530. Don't merge until that PR is merged.

This adds an external test for Bleeps.

The project has an unusual structure compared to the others we have integrated so far (it's a monorepo with pnpm as the recommended package manager) so it was a bit tricky to get just the part we need to build and tests to run. The main branch also seems to be broken right now (wighawag/bleeps#1). Fortunately there's a tag close to the top commit (bleeps_migrations) so I'm using that for now.

Note that the extra parameters my PR adds to neutralize_package_json_hooks are not used. I originally needed them for the common-lib library in the repo but in the and I was able to drop that. They may come in handy later though so I want to keep that change anyway.

@ekpyron
Copy link
Member

ekpyron commented Jan 14, 2022

FYI: (probably trivial) merge conflicts to be resolved after I merged the first one

@cameel
Copy link
Member Author

cameel commented Jan 14, 2022

Conflicts solved. As I said in, #12530 (comment), I'm going to put this PR on top of #12530 now.

@cameel cameel added the has dependencies The PR depends on other PRs that must be merged first label Jan 14, 2022
@ekpyron
Copy link
Member

ekpyron commented Jan 14, 2022

Wait, why does the commit of #12350 still show up here after that's merged? Ah, I guess that's what happens, if you don't also switch the base branch on github? Anyways, the test run seems to fail, so I'll have another look next week.

@cameel
Copy link
Member Author

cameel commented Jan 14, 2022

Yeah, sorry looks like I did forget to switch the base branch :)

It's fails because the maintainer fixed wighawag/bleeps#1 and I pushed a commit to switch it to main, hoping that it now passes tests. I think it would if not for the fact that the project now contains one 0.4.19 contract that won't compile with 0.8.11 :(

So back to the tag we go. I'll revert it to the previous version.

@cameel
Copy link
Member Author

cameel commented Jan 14, 2022

Fixed. It should pass tests now.

@cameel cameel removed the has dependencies The PR depends on other PRs that must be merged first label Jan 14, 2022
@hrkrshnn hrkrshnn merged commit 7b58afa into develop Jan 17, 2022
@hrkrshnn hrkrshnn deleted the bleeps-ext-test branch January 17, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants