-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External test for Bleeps #12531
External test for Bleeps #12531
Conversation
1ec0bc2
to
8977189
Compare
FYI: (probably trivial) merge conflicts to be resolved after I merged the first one |
8977189
to
235c16b
Compare
Conflicts solved. As I said in, #12530 (comment), I'm going to put this PR on top of #12530 now. |
235c16b
to
ee85f48
Compare
Wait, why does the commit of #12350 still show up here after that's merged? Ah, I guess that's what happens, if you don't also switch the base branch on github? Anyways, the test run seems to fail, so I'll have another look next week. |
Yeah, sorry looks like I did forget to switch the base branch :) It's fails because the maintainer fixed wighawag/bleeps#1 and I pushed a commit to switch it to So back to the tag we go. I'll revert it to the previous version. |
d4d7d19
to
1af0ce0
Compare
Fixed. It should pass tests now. |
Part of #5956.
Depends on #12530. Don't merge until that PR is merged.
This adds an external test for Bleeps.
The project has an unusual structure compared to the others we have integrated so far (it's a monorepo with
pnpm
as the recommended package manager) so it was a bit tricky to get just the part we need to build and tests to run. Themain
branch also seems to be broken right now (wighawag/bleeps#1). Fortunately there's a tag close to the top commit (bleeps_migrations
) so I'm using that for now.Note that the extra parameters my PR adds to
neutralize_package_json_hooks
are not used. I originally needed them for thecommon-lib
library in the repo but in the and I was able to drop that. They may come in handy later though so I want to keep that change anyway.