Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes solidity upgrade #13778

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Removes solidity upgrade #13778

merged 1 commit into from
Jan 18, 2023

Conversation

Andy53
Copy link
Contributor

@Andy53 Andy53 commented Dec 3, 2022

Removes solidity upgrade. Fixes #13715

@github-actions
Copy link

github-actions bot commented Dec 3, 2022

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@Andy53 Andy53 marked this pull request as ready for review December 12, 2022 15:02
ekpyron
ekpyron previously requested changes Jan 5, 2023
docs/using-the-compiler.rst Outdated Show resolved Hide resolved
@Andy53 Andy53 requested a review from ekpyron January 6, 2023 16:53
@nikola-matic
Copy link
Collaborator

@ekpyron should this be mentioned in the changelog? I only see one entry related to solidity-upgrade and it's a bug fix.

@ekpyron
Copy link
Member

ekpyron commented Jan 17, 2023

@ekpyron should this be mentioned in the changelog? I only see one entry related to solidity-upgrade and it's a bug fix.

Technically, it probably should, but since I don't think anyone uses it, and we haven't tracked it there, I'm fine with just merging.

nikola-matic
nikola-matic previously approved these changes Jan 17, 2023
@ekpyron
Copy link
Member

ekpyron commented Jan 17, 2023

@ekpyron should this be mentioned in the changelog? I only see one entry related to solidity-upgrade and it's a bug fix.

Technically, it probably should, but since I don't think anyone uses it, and we haven't tracked it there, I'm fine with just merging.

On a second thought: since solidity-upgrade is actually packaged downstream (e.g. in https://archlinux.org/packages/community/x86_64/solidity/), maybe it's better to have a short note about it in the Changelog after all.

@ekpyron ekpyron dismissed their stale review January 17, 2023 14:38

Change request in the docs was addressed.

@Andy53 Andy53 requested review from nikola-matic and ekpyron and removed request for ekpyron and nikola-matic January 17, 2023 14:55
Changelog.md Outdated Show resolved Hide resolved
update config.yaml

Update using-the-compiler.rst

removed bug reports section

added changelog entry

removed trailing whitespace

removed trailing whitespace
@Andy53 Andy53 requested review from nikola-matic and ekpyron and removed request for ekpyron and nikola-matic January 17, 2023 16:48
@ekpyron ekpyron merged commit c195782 into ethereum:develop Jan 18, 2023
@Andy53 Andy53 deleted the removes-solidity-upgrade branch July 15, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove solidity-upgrade
3 participants