Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize CLI tests #14339

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Parallelize CLI tests #14339

merged 1 commit into from
Jun 21, 2023

Conversation

cameel
Copy link
Member

@cameel cameel commented Jun 20, 2023

This PR takes advantage of the recent improvements to the CLI test runner (#14289, #14338) to single out several particularly long CLI tests and run them in parallel. This makes the _cli jobs finish 2x faster.

Bigger savings are possible, but with a lot more effort to make test selection more granular. Especially ~ast_import_export takes half of the running time and is currently a single test. Once we have better granularity we could also use CircleCI's time-based splitting, but that requires further changes - we'd need to generate JUnit-style XML reports. I'm not doing all that here. The goal of this PR is just to pick the low-hanging fruit while parallelizing the bytecode comparison tests (#14330) to prevent the byte comparison jobs from taking excessively long time in CI after #13583.

Copy link
Collaborator

@matheusaaguiar matheusaaguiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t_osx_cli went from 33 to 12 minutes. Nice!

@cameel cameel merged commit b26090c into develop Jun 21, 2023
2 checks passed
@cameel cameel deleted the parallelize-cli-tests branch June 21, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants