Disallow the use of MagicType in complex expressions
#14371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusaaguiar
force-pushed
the
overrideMagicType_mobileType
branch
from
5d4520e
to
e93bb7f
Compare
cameel
reviewed
Jul 11, 2023
test/libsolidity/syntaxTests/metaTypes/type_max_from_ternary_expression.sol
Show resolved
Hide resolved
test/libsolidity/syntaxTests/inline_arrays/unnamed_types_in_inline_array_3.sol
Outdated
Show resolved
Hide resolved
matheusaaguiar
force-pushed
the
overrideMagicType_mobileType
branch
from
fb133c3
to
eee852b
Compare
matheusaaguiar
commented
Jul 12, 2023
test/libsolidity/syntaxTests/inline_arrays/unnamed_types_in_inline_array_1.sol
Show resolved
Hide resolved
matheusaaguiar
force-pushed
the
overrideMagicType_mobileType
branch
from
5b3a88d
to
4d51d0c
Compare
matheusaaguiar
force-pushed
the
overrideMagicType_mobileType
branch
from
1ec6c06
to
efdaaf0
Compare
cameel
requested changes
Jul 13, 2023
test/libsolidity/semanticTests/expressions/tuple_from_ternary_expression.sol
Outdated
Show resolved
Hide resolved
test/libsolidity/semanticTests/expressions/module_from_ternary_expression.sol
Show resolved
Hide resolved
cameel
changed the title
MagicType::mobileType returning nullptrMagicType in complex expressions
matheusaaguiar
force-pushed
the
overrideMagicType_mobileType
branch
from
efdaaf0
to
e265e9d
Compare
|
Looks good now. The only remaining thing is the bug list entry. |
cameel
previously approved these changes
Jul 14, 2023
matheusaaguiar
force-pushed
the
overrideMagicType_mobileType
branch
from
e265e9d
to
0634543
Compare
|
Rebased. |
ekpyron
previously requested changes
Jul 17, 2023
cameel
force-pushed
the
overrideMagicType_mobileType
branch
from
0634543
to
f3fc190
Compare
cameel
dismissed
ekpyron’s stale review
The changelog issue was resolved and Daniel is off today so he would not be able to reapprove anywya.
nikola-matic
approved these changes
Jul 18, 2023
Comment on lines
+7
to
+8
| // TypeError 9717: (98-109): Invalid mobile type in true expression. | ||
| // TypeError 3703: (112-122): Invalid mobile type in false expression. |
There was a problem hiding this comment.
Kinda weird that these are separate errors, but not really an issue for now :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.