Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs website] Patch version menu overflow [Fixes #14429] #14431

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Jul 19, 2023

Description

  • Adds max-height and overflow-y scroll to "other versions" menu, fixing the overflow bug that was preventing users from closing the menu once opened.

Preview deploy

https://solidity-docs-dev--2.org.readthedocs.build/en/2/
(Built from personal fork)
I added a handful of versions to the preview above, so this can be tested by shortening the height of the window on above preview and opening the versions menu:

image

The "RTD" bar should now remain visible at the top to close the menu, and the rest should be scrollable.

Related issue

@github-actions
Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@wackerow wackerow changed the title Patch version menu overflow [Fixes #14429] [Docs website] Patch version menu overflow [Fixes #14429] Jul 19, 2023
Copy link
Contributor

@NunoFilipeSantos NunoFilipeSantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks alright now!

@NunoFilipeSantos NunoFilipeSantos merged commit 4fa48a6 into ethereum:develop Jul 24, 2023
Ruko97 pushed a commit to Ruko97/solidity that referenced this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs website] "Versions" menu not scrollable, overflow preventing ability to close
3 participants