Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs website] Fix docs layout and link bugs [Fixes #14436] #14439

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Jul 20, 2023

Description

  • Adjusts layout to allow window scrolling to properly scroll content (was previously a fixed window, and content div was set to overflow-y: scroll;
  • Removes old font assets in lieu of cdnfonts import

This fixes the bug where hash links from the menu were not taking user to the proper scroll position. Links in menu will now immediately bring user to associated section of the content.

Preview deploy

https://solidity-docs-dev--1.org.readthedocs.build/en/1/
(Built from personal fork)

Related issue

Copy link
Contributor

@NunoFilipeSantos NunoFilipeSantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@NunoFilipeSantos
Copy link
Contributor

@wackerow can you please check the merge conflicts?

Copy link
Contributor

@NunoFilipeSantos NunoFilipeSantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@NunoFilipeSantos NunoFilipeSantos enabled auto-merge (squash) July 25, 2023 11:22
using cdnfonts import instead

fix mobile menu layout

fix mobile content positioning/sizing

fix desktop content widths

prevent header links from wrapping

update desktop positioning

fix backdrop-filter

move to .unified-header::before

feat: independent scrolling for content and menu
@NunoFilipeSantos NunoFilipeSantos merged commit 0fa594e into ethereum:develop Jul 26, 2023
Ruko97 pushed a commit to Ruko97/solidity that referenced this pull request Apr 7, 2024
using cdnfonts import instead

fix mobile menu layout

fix mobile content positioning/sizing

fix desktop content widths

prevent header links from wrapping

update desktop positioning

fix backdrop-filter

move to .unified-header::before

feat: independent scrolling for content and menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs website] Hash links not navigating to proper scroll position
3 participants