Fix several minor typo #14629
Fix several minor typo #14629
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
docs/installing-solidity.rst
Outdated
| Use the ``stable`` tag for the latest released version, and ``nightly`` for potentially unstable changes in the develop branch. | ||
| Use the ``stable`` tag for the latest released version, and ``nightly`` for potentially unstable changes in the development branch. |
There was a problem hiding this comment.
This is not a typo - the branch is named develop.
There was a problem hiding this comment.
Hi ekpyron, thanks for your review.
In this document, "development branch" was also mentioned above: "they contain bleeding-edge code from the development branch and are not guaranteed to be always working."
I think it makes sense to make it consistent.
What do you think?
There was a problem hiding this comment.
No, what he means is that our main branch is named develop and that sentence mentions this branch.
So I would suggest it to:
| Use the ``stable`` tag for the latest released version, and ``nightly`` for potentially unstable changes in the develop branch. | |
| Use the ``stable`` tag for the latest released version, and ``nightly`` for potentially unstable changes in the development branch. | |
| Use the ``stable`` tag for the latest released version, and ``nightly`` for potentially unstable changes in the ``develop`` branch. |
There was a problem hiding this comment.
@r0qs: Thanks for your suggestion, this is really helpful!
I've modified now the sentence according to your suggestion.
Update installing-solidity.rst
* fix minor typo * fix minor typo * Change to suggested correct wording Update installing-solidity.rst
* fix minor typo * fix minor typo * Change to suggested correct wording Update installing-solidity.rst
* fix minor typo * fix minor typo * Change to suggested correct wording Update installing-solidity.rst
* fix minor typo * fix minor typo * Change to suggested correct wording Update installing-solidity.rst
* fix minor typo * fix minor typo * Change to suggested correct wording Update installing-solidity.rst
No description provided.