-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Cancun
EVM version
#14705
Introduce Cancun
EVM version
#14705
Conversation
4980f2d
to
6b36e4d
Compare
6b36e4d
to
c733d06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good already - can you also check if there's a new version of evmc/evmone we need to update to? I think the latest one should have decent cancun support (including transient storage), but haven't checked, if we're up to date with it.
We are using the latest evmone release, i.e. |
Are you sure? I thought Andrej said at some point that they already had it - but maybe he just meant merged on master, not released - can you ping them (maybe in our EOF channels), though, about when to expect a release? Maybe they'll release very soon, then we don't need to switch to a git build for it everywhere. |
Yes, exactly. It has been merged into the master branch but has not been released yet (https://github.com/ethereum/evmone/releases). However, considering that evmc was updated to version 11.0.0 today (ethereum/evmone@ecc83d9), they might indeed release it soon. I took a look at our current evmone build scripts, and it seems we'll need to modify the Windows and MacOS scripts to build from source instead of downloading the binaries. So, it might be worthwhile to wait for a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR could also already add an entry to the Target Options list under Using the Compiler
section in the docs. But that's optional and could be done in the future.
Other than that, everything looks ok and according to what was done before when introducing shanghai.
I guess it is better to add the entry to the Target Options in the branch that implements transient storage, because this one here does not add any opcodes for example. |
c733d06
to
0022089
Compare
I just did a simple It might be the only thing missing, but better to double-check :-). |
Yes, I didn't add it for the same reason of this comment: #14705 (comment), because this PR does nothing besides only add the Cancun EVM version compiler option. I thought it would make more sense to add the docs with the actual implementation of it. But I can change that and already try to add some details about transient storage. |
No description provided.