Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Cancun EVM version #14705

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Introduce Cancun EVM version #14705

merged 1 commit into from
Dec 13, 2023

Conversation

r0qs
Copy link
Member

@r0qs r0qs commented Nov 28, 2023

No description provided.

@r0qs r0qs force-pushed the add-cancun-evm-version branch from 4980f2d to 6b36e4d Compare November 28, 2023 12:44
@nikola-matic nikola-matic force-pushed the add-cancun-evm-version branch from 6b36e4d to c733d06 Compare November 28, 2023 14:36
Copy link
Member

@ekpyron ekpyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good already - can you also check if there's a new version of evmc/evmone we need to update to? I think the latest one should have decent cancun support (including transient storage), but haven't checked, if we're up to date with it.

@r0qs
Copy link
Member Author

r0qs commented Nov 29, 2023

Looks good already - can you also check if there's a new version of evmc/evmone we need to update to? I think the latest one should have decent cancun support (including transient storage), but haven't checked, if we're up to date with it.

We are using the latest evmone release, i.e. 0.10.0, and support for cancun was added in the master branch and not released yet. Also, they updated evmc to 11.0.0 on the master branch as well. So, we should update our CI to use the master branch instead of v0.10.0 branch. I will do that in another PR ;)

@ekpyron
Copy link
Member

ekpyron commented Nov 29, 2023

Looks good already - can you also check if there's a new version of evmc/evmone we need to update to? I think the latest one should have decent cancun support (including transient storage), but haven't checked, if we're up to date with it.

We are using the latest evmone release, i.e. 0.10.0, and support for cancun was added in the master branch and not released yet. Also, they updated evmc to 11.0.0 on the master branch as well. So, we should update our CI to use the master branch instead of v0.10.0 branch. I will do that in another PR ;)

Are you sure? I thought Andrej said at some point that they already had it - but maybe he just meant merged on master, not released - can you ping them (maybe in our EOF channels), though, about when to expect a release? Maybe they'll release very soon, then we don't need to switch to a git build for it everywhere.

@r0qs
Copy link
Member Author

r0qs commented Nov 29, 2023

Looks good already - can you also check if there's a new version of evmc/evmone we need to update to? I think the latest one should have decent cancun support (including transient storage), but haven't checked, if we're up to date with it.

We are using the latest evmone release, i.e. 0.10.0, and support for cancun was added in the master branch and not released yet. Also, they updated evmc to 11.0.0 on the master branch as well. So, we should update our CI to use the master branch instead of v0.10.0 branch. I will do that in another PR ;)

Are you sure? I thought Andrej said at some point that they already had it - but maybe he just meant merged on master, not released - can you ping them (maybe in our EOF channels), though, about when to expect a release? Maybe they'll release very soon, then we don't need to switch to a git build for it everywhere.

Yes, exactly. It has been merged into the master branch but has not been released yet (https://github.com/ethereum/evmone/releases). However, considering that evmc was updated to version 11.0.0 today (ethereum/evmone@ecc83d9), they might indeed release it soon.

I took a look at our current evmone build scripts, and it seems we'll need to modify the Windows and MacOS scripts to build from source instead of downloading the binaries. So, it might be worthwhile to wait for a bit.

Copy link
Collaborator

@matheusaaguiar matheusaaguiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR could also already add an entry to the Target Options list under Using the Compiler section in the docs. But that's optional and could be done in the future.
Other than that, everything looks ok and according to what was done before when introducing shanghai.

@r0qs
Copy link
Member Author

r0qs commented Nov 30, 2023

This PR could also already add an entry to the Target Options list under Using the Compiler section in the docs. But that's optional and could be done in the future. Other than that, everything looks ok and according to what was done before when introducing shanghai.

I guess it is better to add the entry to the Target Options in the branch that implements transient storage, because this one here does not add any opcodes for example.

@r0qs r0qs marked this pull request as ready for review November 30, 2023 16:36
@r0qs r0qs force-pushed the add-cancun-evm-version branch from c733d06 to 0022089 Compare November 30, 2023 16:36
@ekpyron
Copy link
Member

ekpyron commented Dec 4, 2023

I just did a simple git grep shanghai check to double-check that this PR covers everything - I haven't gone through the entire list, but at least docs/using-the-compiler.rst should mention it - any reason not to include it there just yet?

It might be the only thing missing, but better to double-check :-).

@r0qs
Copy link
Member Author

r0qs commented Dec 4, 2023

I just did a simple git grep shanghai check to double-check that this PR covers everything - I haven't gone through the entire list, but at least docs/using-the-compiler.rst should mention it - any reason not to include it there just yet?

Yes, I didn't add it for the same reason of this comment: #14705 (comment), because this PR does nothing besides only add the Cancun EVM version compiler option. I thought it would make more sense to add the docs with the actual implementation of it. But I can change that and already try to add some details about transient storage.

@ekpyron ekpyron merged commit ad9271e into develop Dec 13, 2023
65 checks passed
@ekpyron ekpyron deleted the add-cancun-evm-version branch December 13, 2023 14:03
@ekpyron ekpyron mentioned this pull request Dec 20, 2023
9 tasks
@ekpyron ekpyron mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants