Testing enhancements for MCOPY
#14790
Conversation
cameel
force-pushed
the
testing-tweaks-before-mcopy
branch
from
2222ea4 to
b26d5fd
Compare
| @@ -58,13 +61,14 @@ TestCase::TestResult MemoryGuardTest::run(std::ostream& _stream, std::string con | |||
| ErrorList errors; | |||
| auto [object, analysisInfo] = yul::test::parse( | |||
| compiler().yulIR(contractName), | |||
| EVMDialect::strictAssemblyForEVMObjects({}), | |||
| EVMDialect::strictAssemblyForEVMObjects(CommonOptions::get().evmVersion()), | |||
There was a problem hiding this comment.
Haha, I assumed we had no memory guards tests with anything other than the default version then?
There was a problem hiding this comment.
Yeah, we didn't. I don't think it's dependent on EVM version in a significant way though. Even now, I only had to change it because this preparatory Yul parsing step won't parse mcopy on earlier EVMs and not because of anything specifically related to the memory guard.
…when printing errors
cameel
force-pushed
the
testing-tweaks-before-mcopy
branch
from
b26d5fd to
7f79cd8
Compare
| @@ -129,6 +119,9 @@ BOOST_AUTO_TEST_CASE(simple_contract) | |||
| BOOST_AUTO_TEST_CASE(store_keccak256) | |||
| { | |||
| char const* sourceCode = R"( | |||
| // TODO: We should enable v2 again once the yul optimizer is activated. | |||
There was a problem hiding this comment.
Just out of curiosity, but where the yul optimizer was deactivated? Should we mention a specific open issue?
There was a problem hiding this comment.
Not sure. The only context I have is #5102 and there's no discussion of that in there. My assumption is that abicoder v2 encoder must be using some EVM feature that GasMeter did not properly account for at that time and the assumption was that it would no longer be a problem when it becomes the default.
I don't think we have an issue for it. Actually, could you create one?
Prerequisite for #14779.
A bunch of enhancements to the test framework that I did while working on
MSIZE. Some of my tests depend on them:GasMeter.cppwere apparently disabled on abicoder v2 in Run all end-to-end tests with ABIEncoderV2 #5102. Most of them work fine though, so I changed it back so that both v1 and v2 run by default and only those few tests that are broken have a bypass.AnalysisFrameworkbased test to make them print errors properly prefixed with the right indent.EVMInstructionInterpreter.hrefactors that I originally had in Yul builtin forMCOPY#14779.