Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hardhat networks settings external tests #14932

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

r0qs
Copy link
Member

@r0qs r0qs commented Mar 12, 2024

Note that t_ems_ext_hardhat will be fixed by PR #14933 when we switch evm version to cancun by default.

@r0qs r0qs requested a review from cameel March 12, 2024 18:23
cameel
cameel previously approved these changes Mar 12, 2024
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, but you should add a comment about the version bump (downgrade)?

test/externalTests/elementfi.sh Outdated Show resolved Hide resolved
@r0qs r0qs force-pushed the add-hardhat-networks-settings-ext-tests branch 3 times, most recently from b4c12b2 to 8a44249 Compare March 13, 2024 12:23
@r0qs r0qs force-pushed the add-hardhat-networks-settings-ext-tests branch from 8a44249 to 6b3ca24 Compare March 13, 2024 12:25
@r0qs r0qs enabled auto-merge March 13, 2024 12:52
@r0qs r0qs requested a review from cameel March 13, 2024 13:17
@r0qs r0qs merged commit 9065a0a into develop Mar 13, 2024
73 checks passed
@r0qs r0qs deleted the add-hardhat-networks-settings-ext-tests branch March 13, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants