Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error msg for hex number combined with unit denomination #14998

Conversation

pcw109550
Copy link
Contributor

days is the correct time unit.

Copy link

github-actions bot commented Apr 8, 2024

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@pcw109550 pcw109550 force-pushed the pcw109550/fix-err-msg-days-hex-number-combination branch from 823c94c to b0126dc Compare April 8, 2024 02:26
@nikola-matic nikola-matic force-pushed the pcw109550/fix-err-msg-days-hex-number-combination branch from b0126dc to e07ace2 Compare April 8, 2024 11:01
@cameel cameel force-pushed the pcw109550/fix-err-msg-days-hex-number-combination branch from e07ace2 to d591ca0 Compare April 8, 2024 14:41
cameel
cameel previously approved these changes Apr 8, 2024
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but for some reason CircleCI jobs are not getting triggered.

A workaround would be to create a branch on our side so that they run from our account.

@pcw109550 pcw109550 force-pushed the pcw109550/fix-err-msg-days-hex-number-combination branch from d591ca0 to 0c32ddb Compare April 8, 2024 17:49
@pcw109550 pcw109550 requested a review from cameel April 8, 2024 22:53
@cameel cameel merged commit ae9bcab into ethereum:develop Apr 9, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants