Prevent NameSimplifier and VarNameCleaner from producing Yul identifiers with leading and trailing dots #15149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/cmdlineTests/yul_leading_or_trailing_dot_in_name/input.yul
Outdated
Show resolved
Hide resolved
cameel
reviewed
May 27, 2024
There was a problem hiding this comment.
Also some general remarks:
- The PR is missing a changelog entry.
- When a PR fixes everything in the original issue you should use the github feature that will fix the issue automatically when the PR is merged. I.e. just add
Fixes #11496in the PR description. - I saw that the issue was moved to the 'In progress' column on the triage board. That column actually means that triage is progress :) It was added so that multiple people don't waste time triaging the same issue at the same time. The issues are only really meant to spent a short time there - triage never really takes all that long.
test/cmdlineTests/yul_leading_or_trailing_dot_in_name/input.yul
Outdated
Show resolved
Hide resolved
test/cmdlineTests/yul_leading_or_trailing_dot_in_name/input.yul
Outdated
Show resolved
Hide resolved
cameel
changed the title
cameel
changed the title
Just noticed that you do have this but it's in the commit message. I'd recommend against it since this adds a lot of noise to the issue you mention this way - the commit appears there again and again each time you rebase the branch. It works much better when used in the PR instead. |
clonker
force-pushed
the
yul_leading_trailing_dot_in_identifier
branch
3 times, most recently
from
f96d849 to
d4c4b06
Compare
Ahh I have misunderstood the "in progress" :) thanks for pointing that out! |
clonker
force-pushed
the
yul_leading_trailing_dot_in_identifier
branch
2 times, most recently
from
d5aadd0 to
947198b
Compare
nikola-matic
previously approved these changes
May 28, 2024
cameel
reviewed
May 28, 2024
clonker
force-pushed
the
yul_leading_trailing_dot_in_identifier
branch
2 times, most recently
from
6c97388 to
7f89de1
Compare
cameel
previously approved these changes
May 28, 2024
clonker
force-pushed
the
yul_leading_trailing_dot_in_identifier
branch
from
7f89de1 to
bbd5e2e
Compare
|
Whelp, forgot to update the test outcome after updating indentations, care to re-approve @cameel ?:) |
nikola-matic
approved these changes
May 28, 2024
cameel
approved these changes
May 28, 2024
nikola-matic
added a commit
that referenced
this pull request
Jun 3, 2024
Fix changelog entry for #15149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11496