BlockHasher: Do not hash literal kind #15231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clonker
force-pushed
the
no_literal_kind_in_block_hash
branch
from
1a9e840 to
0333a55
Compare
ekpyron
reviewed
Jul 1, 2024
ekpyron
reviewed
Jul 1, 2024
test/libsolidity/semanticTests/array/copying/function_type_array_to_storage.sol
Show resolved
Hide resolved
ekpyron
previously approved these changes
Jul 1, 2024
There was a problem hiding this comment.
I'm approving this - though technically, we could even give it a changelog entry - it does in fact affect some cases, we could say something like the optimizer treating some literals that are identical, but weren't recognized as identical as identical in Yul or so (ideally phrased more concisely)
clonker
force-pushed
the
no_literal_kind_in_block_hash
branch
from
0333a55 to
ce02133
Compare
added a changelog entry in the spirit of what you proposed |
ekpyron
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.