Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump evmone to v0.12.0 and add ubuntu2404 image #15321

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

nikola-matic
Copy link
Collaborator

No description provided.

@nikola-matic nikola-matic requested a review from r0qs August 9, 2024 08:36
@nikola-matic nikola-matic self-assigned this Aug 9, 2024
@nikola-matic nikola-matic changed the title Bump evmone to v0.12.0 in CI Bump evmone to v0.12.0 Aug 9, 2024
@nikola-matic nikola-matic marked this pull request as draft August 12, 2024 10:55
cmake \
clang-15 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the exact reason for the specific version meddling here, i.e. what exactly breaks without that? The very purpose of these images is to test something close to a default configuration, so messing with that too much is kinda against the point of these - and also strange that 20.04 gcc seems fine with whatever triggers this, while default 22.04 clang isn't :-).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we install non-default versions in this one, we can also consider switching to 24.04 for the clang image.

We also need to add a gcc 24.04 image anyways by the way.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-15 is now the minimum required version to build evmone.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we install non-default versions in this one, we can also consider switching to 24.04 for the clang image.

We also need to add a gcc 24.04 image anyways by the way.

ossfuzz is still gonna be a problem since the Google team that maintains it doesn't really wanna upgrade their base images, which are still on focal (20.04) - google/oss-fuzz#11835

All in all, kinda annoying :)

Copy link
Member

@ekpyron ekpyron Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any problem with just pulling in the binaries for evmone (that's done for the 20.04 gcc images already anyways)? There's little point in us testing the builds for them - and changing our compiler setup for building a testing-only dependency is rather weird :-).

@nikola-matic nikola-matic marked this pull request as ready for review August 14, 2024 09:34
@ekpyron ekpyron added the 🟡 PR review label label Aug 15, 2024
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2204-10 [solbuildpackpusher/solidity-buildpack-deps@sha256:ba2d878c26d681a7d6c1922258b47c2e5dd61d0e46ab4c6a4862b473e61997b6].

Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2204.clang-9 [solbuildpackpusher/solidity-buildpack-deps@sha256:703cdad5fa5c8686a3080ebb1aea1485ded2446561bf56e2945a87f2fa20a446].

Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2404-1 [solbuildpackpusher/solidity-buildpack-deps@sha256:5d6d27551104321a30326d6024bd4e96d9d899a97a78eb9feea364996f1d18b5].

Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2004-25 [solbuildpackpusher/solidity-buildpack-deps@sha256:b3f321fb2d8e7a41ca9328672061c1840e5cd3fb5be503aa158d1c508deacf0a].

@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 21, 2024
Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But will we run tests using the ubuntu2404 image in the CI? If so, we need another PR adding it to the CircleCi config.

@nikola-matic
Copy link
Collaborator Author

LGTM. But will we run tests using the ubuntu2404 image in the CI? If so, we need another PR adding it to the CircleCi config.

I'd prefer to do that in another PR so as not to trigger yet another buildpack-deps build. By the way, if I merge this now, I assume a new buildpack-deps build will be triggered on develop (do we stop these manually, or just let them run)?

@r0qs
Copy link
Member

r0qs commented Aug 21, 2024

LGTM. But will we run tests using the ubuntu2404 image in the CI? If so, we need another PR adding it to the CircleCi config.

I'd prefer to do that in another PR so as not to trigger yet another buildpack-deps build. By the way, if I merge this now, I assume a new buildpack-deps build will be triggered on develop (do we stop these manually, or just let them run)?

If I'm not mistaken, the action is only triggered on PRs targeting the develop branch, so merging will not run it.

@nikola-matic nikola-matic merged commit 431911d into develop Aug 26, 2024
78 checks passed
@nikola-matic nikola-matic deleted the bump-evmc-and-evmone-to-12 branch August 26, 2024 09:18
@r0qs r0qs changed the title Bump evmone to v0.12.0 Bump evmone to v0.12.0 and add ubuntu2404 image Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟡 PR review label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants