-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump evmone to v0.12.0 and add ubuntu2404 image #15321
Conversation
39cbf47
to
719791b
Compare
cmake \ | ||
clang-15 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the exact reason for the specific version meddling here, i.e. what exactly breaks without that? The very purpose of these images is to test something close to a default configuration, so messing with that too much is kinda against the point of these - and also strange that 20.04 gcc seems fine with whatever triggers this, while default 22.04 clang isn't :-).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we install non-default versions in this one, we can also consider switching to 24.04 for the clang image.
We also need to add a gcc 24.04 image anyways by the way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-15 is now the minimum required version to build evmone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we install non-default versions in this one, we can also consider switching to 24.04 for the clang image.
We also need to add a gcc 24.04 image anyways by the way.
ossfuzz is still gonna be a problem since the Google team that maintains it doesn't really wanna upgrade their base images, which are still on focal (20.04) - google/oss-fuzz#11835
All in all, kinda annoying :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any problem with just pulling in the binaries for evmone (that's done for the 20.04 gcc images already anyways)? There's little point in us testing the builds for them - and changing our compiler setup for building a testing-only dependency is rather weird :-).
719791b
to
c29d27d
Compare
Bump clang to 15
5776716
to
44f7c3b
Compare
0d7c3a3
to
5d2f90c
Compare
5d2f90c
to
1c21f83
Compare
|
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But will we run tests using the ubuntu2404
image in the CI? If so, we need another PR adding it to the CircleCi config.
I'd prefer to do that in another PR so as not to trigger yet another buildpack-deps build. By the way, if I merge this now, I assume a new buildpack-deps build will be triggered on develop (do we stop these manually, or just let them run)? |
If I'm not mistaken, the action is only triggered on PRs targeting the |
No description provided.