Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change toBigEndian interface to support rvalue ref. #15357

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

rodiazet
Copy link
Contributor

No description provided.

Co-authored-by: Daniel Kirchner <daniel@ekpyron.org>
Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

Copy link
Member

@ekpyron ekpyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a bit funky without seeing the use cases where it's rvalue bytesRefs, but with that in mind it does make sense.

@ekpyron ekpyron merged commit 2b7274c into ethereum:develop Aug 23, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants