Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eof: Semantic tests update #15665

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

eof: Semantic tests update #15665

wants to merge 2 commits into from

Conversation

rodiazet
Copy link
Contributor

@rodiazet rodiazet commented Dec 19, 2024 •
edited
Loading

  • Disable some tests which don't make sense for EOF.
  • Modify tests to make them EOF compatible and move them to separated folders
  • Adjust test expectation to avoid using deployed contract address as it can change between optimized and non-optimized versions for EOF

@github-actions GitHub Actions
Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@rodiazet rodiazet mentioned this pull request Dec 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
EOF external contribution ⭐ testing 🔨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodiazet @cameel