Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar & Clarity Fixes #15882

Closed
wants to merge 6 commits into from
Closed

Grammar & Clarity Fixes #15882

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6cc02e4
Update bleeps.sh
NeoByteXx Feb 20, 2025
7ed2443
Update brink.sh
NeoByteXx Feb 20, 2025
b7f1fc9
Update elementfi.sh
NeoByteXx Feb 20, 2025
8d602b2
Update bleeps.sh
NeoByteXx Feb 21, 2025
d6019a3
Merge branch 'develop' into develop
NeoByteXx Feb 21, 2025
ae263a1
Merge branch 'develop' into develop
NeoByteXx Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/externalTests/bleeps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function bleeps_test
local compile_only_presets=()
local settings_presets=(
"${compile_only_presets[@]}"
#ir-no-optimize # Compilation fails with: "YulException: Variable expr_15509_mpos is 4 too deep in the stack". No memoryguard was present.
#ir-no-optimize # Compilation fails with: "YulException: Variable expr_15509_mpos is 4 too deep in the stack". No memory guard was present.
#ir-optimize-evm-only # Compilation fails with: "YulException: Variable expr_15260_mpos is 4 too deep in the stack". No memoryguard was present.
#ir-optimize-evm+yul # Compilation fails with: "YulException: Variable expr_15208_mpos is 1 too deep in the stack". No memoryguard was present.
#legacy-no-optimize # Compilation fails with: "CompilerError: Stack too deep, try removing local variables."
Expand Down
2 changes: 1 addition & 1 deletion test/externalTests/brink.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ function brink_test
setup_solc "$DIR" "$BINARY_TYPE" "$BINARY_PATH"
download_project "$repo" "$ref" "$DIR"

# TODO: Remove this when Brink merges https://github.com/brinktrade/brink-core/pull/52
# TODO: Remove this once Brink merges PR #52 (https://github.com/brinktrade/brink-core/pull/52).
sed -i "s|\(function isValidSignature(bytes \)calldata\( _data, bytes \)calldata\( _signature)\)|\1memory\2memory\3|g" src/Test/MockEIP1271Validator.sol

neutralize_package_lock
Expand Down
4 changes: 2 additions & 2 deletions test/externalTests/elementfi.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ function elementfi_test
sed -i 's|it(\("should prevent withdrawal of Principal Tokens and Interest Tokens before the tranche expires "\)|it.skip(\1|g' test/trancheTest.ts
sed -i 's|it(\("should prevent withdrawal of more Principal Tokens and Interest Tokens than the user has"\)|it.skip(\1|g' test/trancheTest.ts

# This test file is very flaky. There's one particular cases that fails randomly (see
# https://github.com/element-fi/elf-contracts/issues/240) but some others also depends on an external
# This test file is very flaky. There's one particular case that fails randomly (see
# https://github.com/element-fi/elf-contracts/issues/240) but some others also depend on an external
# service which makes tests time out when that service is down.
# "ProviderError: Too Many Requests error received from eth-mainnet.alchemyapi.io"
rm test/mockERC20YearnVaultTest.ts
Expand Down