Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSACFG Builder: Improve function call visitor #15950

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

clonker
Copy link
Member

@clonker clonker commented Mar 17, 2025

Use visitor instead of if-else construct so we get a compiler error if the underlying variant is modified.

@clonker clonker requested a review from r0qs March 17, 2025 07:54
@clonker clonker added refactor 🟡 PR review label labels Mar 17, 2025
Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clonker clonker merged commit 9620f4f into develop Mar 18, 2025
75 checks passed
@clonker clonker deleted the ssacfg_builder_improve_function_call_visitor branch March 18, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 🟡 PR review label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants