Skip to content

Support ethdebug source locations under EOF #15994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

clonker
Copy link
Member

@clonker clonker commented Apr 10, 2025

  • Adds an EthdebugSchema header with the relevant part of the schema mapped to structs with corresponding to_json methods and validations
  • Skips the context for instructions with source locations that are not valid (ie, (-1, -1))
  • Adds source location info in evmasm assembly for assembleEOF
  • Refactors legacy assemble to use RAII-style instruction location gathering

Fixes the unoptimized part of #15978.
Fixes #15998.

@clonker clonker force-pushed the eof_source_locations_unoptimized branch 2 times, most recently from 20d6a64 to fb559fb Compare April 11, 2025 09:12
@clonker clonker marked this pull request as ready for review April 11, 2025 09:38
@clonker clonker force-pushed the eof_source_locations_unoptimized branch 9 times, most recently from e6a1055 to 2a91773 Compare April 12, 2025 06:49
@clonker clonker requested review from cameel and aarlt April 12, 2025 09:12
@clonker clonker force-pushed the eof_source_locations_unoptimized branch from 2a91773 to 704d58c Compare April 15, 2025 06:39
@clonker clonker force-pushed the eof_source_locations_unoptimized branch 3 times, most recently from 67f2a96 to d82b70c Compare April 15, 2025 07:01
@clonker clonker force-pushed the eof_source_locations_unoptimized branch from d82b70c to 0fd1232 Compare April 15, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EthDebug source range offsets must be non-negative
1 participant