Infrastructure for extracting syntax tests. #3707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 12, 2018
|
Still to be discussed:
|
ekpyron
force-pushed
the
syntaxTestsTestRunner
branch
2 times, most recently
from
cfb1fc3 to
72b815d
Compare
ekpyron
force-pushed
the
syntaxTestsTestRunner
branch
from
72b815d to
3232561
Compare
chriseth
suggested changes
Mar 13, 2018
test/libsolidity/SyntaxTest.cpp
Outdated
| m_errorList = parseAnalyseAndReturnError(m_source, true, true, true).second; | ||
| if (!matchesExpectations(m_errorList)) | ||
| { | ||
| std::string nextIndentLevel = _indent.empty() ? "\t" : _indent + _indent; |
There was a problem hiding this comment.
Why do you double the indentation instead of just adding a \t?
There was a problem hiding this comment.
For the interactive tool isoltest later I use two spaces instead of tabs as indentation - that was the reason, but I agree: doubling the indentation does not really make sense in any case, since passing the indent as argument suggests that it could already be deeper than one level; I'll change it to just add a tab here and think about how to do things in isoltest later.
test/libsolidity/SyntaxTest.cpp
Outdated
| { | ||
| ifstream file(_filename); | ||
| if (!file) | ||
| BOOST_THROW_EXCEPTION(runtime_error("cannot open test contract: \"" + _filename + "\"")); |
test/libsolidity/SyntaxTest.cpp
Outdated
| else | ||
| for (size_t i = 0; i < _errorList.size(); i++) | ||
| if ( | ||
| !(_errorList[i]->typeName() == m_expectations[i].type) || |
There was a problem hiding this comment.
I would say != is easier to read than !( ... == ...)
|
@chriseth Requested changes are ready. |
chriseth
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #3644.
Copies some example test contracts from SolidityNameAndTypeResolution.cpp in separate files in test/libsolidity/syntaxTests/ in which the test expectations are encoded in comments, adds a parser for this encoding and populates the boost test tree with these tests.
Part 1 of #3674.