Skip to content

[soltest] Add support for boolean literals #6072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Conversation

erak
Copy link
Collaborator

@erak erak commented Feb 21, 2019

Part of #4223.

This PR aims to add support for boolean literals in (i)soltest. Boolean literals result in a right-aligned, padded 32-byte representation:

contract C {
    function g(bool x) public returns (bool) {
        return !x;
    }
}
// ----
// g(bool): true -> false

@erak erak self-assigned this Feb 21, 2019
@erak erak changed the title Adds support for boolean literals in soltest. [soltest] Add support for boolean literals Feb 21, 2019
@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #6072 into develop will increase coverage by <.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6072      +/-   ##
==========================================
+ Coverage    88.69%   88.7%   +<.01%     
==========================================
  Files          368     368              
  Lines        35038   35089      +51     
  Branches      4133    4137       +4     
==========================================
+ Hits         31078   31124      +46     
- Misses        2568    2569       +1     
- Partials      1392    1396       +4
Flag Coverage Δ
#all 88.7% <88.88%> (ø) ⬆️
#syntax 27.79% <6.34%> (-0.03%) ⬇️

@chriseth chriseth merged commit dd97a94 into develop Feb 25, 2019
@axic axic deleted the soltest-bool-literals branch February 25, 2019 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants