Add IPFS hash of source files to metadata. #6599

chriseth · 2019-04-25T17:53:41Z

No description provided.

chriseth · 2019-04-25T17:54:00Z

libdevcore/picosha2.h

@@ -0,0 +1,360 @@
+/*


This file was already part of this repository at some point :)

stackenbotten · 2019-04-25T18:03:17Z

There was an error when running test_check_style for commit 7ced487a4f3caee3682d564126ce244eeebc5423:

Error: Trailing whitespace found:
 libdevcore/picosha2.h:38:namespace detail 
 libdevcore/picosha2.h:69: 0x6a09e667, 0xbb67ae85, 0x3c6ef372, 0xa54ff53a, 
 libdevcore/picosha2.h:121: 
 libdevcore/picosha2.h:130: 
 libdevcore/picosha2.h:166: } 
 libdevcore/picosha2.h:214: detail::hash256_block(h_, buffer_.begin()+i, buffer_.begin()+i+64); 
 libdevcore/picosha2.h:266: data_length_digits_, data_length_digits_+4,

Please check that your changes are working as intended.

stackenbotten · 2019-04-25T18:17:38Z

There was an error when running test_check_style for commit 00af3ac48adddde0c1743db6172a533b28ad0110:

Error: Trailing whitespace found:
 libdevcore/picosha2.h:38:namespace detail 
 libdevcore/picosha2.h:69: 0x6a09e667, 0xbb67ae85, 0x3c6ef372, 0xa54ff53a, 
 libdevcore/picosha2.h:121: 
 libdevcore/picosha2.h:130: 
 libdevcore/picosha2.h:166: } 
 libdevcore/picosha2.h:214: detail::hash256_block(h_, buffer_.begin()+i, buffer_.begin()+i+64); 
 libdevcore/picosha2.h:266: data_length_digits_, data_length_digits_+4,

Please check that your changes are working as intended.

axic · 2019-04-25T18:41:18Z

Did you see this https://github.com/axic/offline-ipfs/blob/master/index.js ?

chriseth · 2019-04-25T20:13:26Z

Ah nice! I couldn't find anything similar to your pbdag.proto, though.

codecov · 2019-04-29T21:03:30Z

Codecov Report

❗ No coverage uploaded for pull request base (develop@ca4b1bc). Click here to learn what that means.
The diff coverage is 96.27%.

@@            Coverage Diff             @@
##             develop    #6599   +/-   ##
==========================================
  Coverage           ?   87.02%           
==========================================
  Files              ?      412           
  Lines              ?    40059           
  Branches           ?     4730           
==========================================
  Hits               ?    34862           
  Misses             ?     3628           
  Partials           ?     1569

Flag	Coverage Δ
#all	`87.02% <96.27%> (?)`
#syntax	`25.45% <3.12%> (?)`

stackenbotten · 2019-04-29T21:03:41Z

There was an error when running test_check_style for commit c0098303723ef586fabcd9e45dedec10187ba337:

Error: Trailing whitespace found:
 libdevcore/picosha2.h:130: 
 libdevcore/picosha2.h:139: 
 libdevcore/picosha2.h:189: detail::hash256_block(h_, buffer_.begin()+i, buffer_.begin()+i+64);

Please check that your changes are working as intended.

stackenbotten · 2019-04-30T09:27:09Z

There was an error when running test_check_style for commit bebee0c44bf61c26d32f4c816eb4abd924f2e216:

Coding style error:
 libdevcore/picosha2.h:201: if(remains > 55)
 libdevcore/picosha2.h:230: if(data_length_digits_[i] >= 65536u)
 libdevcore/picosha2.h:217: for (const uint32_t* iter = h_; iter != h_+8; ++iter)
 libdevcore/picosha2.h:51:static const uint32_t add_constant[64] = {
 libdevcore/picosha2.h:70:static const uint32_t initial_message_digest[8] = {
 libdevcore/picosha2.h:77: return (x&y)^((~x)&z);
 libdevcore/picosha2.h:82: return (x&y)^(x&z)^(y&z);
 libdevcore/picosha2.h:219: *(first++) = detail::mask_8bit(static_cast<uint8_t>((*iter >> (24-8*i))));

Please check that your changes are working as intended.

stackenbotten · 2019-05-06T12:45:32Z

There was an error when running test_check_style for commit c31e19ff62b18d7559db1ae5d1af5553fa0e6242:

Coding style error:
 libdevcore/picosha2.h:201: if(remains > 55)
 libdevcore/picosha2.h:230: if(data_length_digits_[i] >= 65536u)
 libdevcore/picosha2.h:217: for (const uint32_t* iter = h_; iter != h_+8; ++iter)
 libdevcore/picosha2.h:51:static const uint32_t add_constant[64] = {
 libdevcore/picosha2.h:70:static const uint32_t initial_message_digest[8] = {
 libdevcore/picosha2.h:77: return (x&y)^((~x)&z);
 libdevcore/picosha2.h:82: return (x&y)^(x&z)^(y&z);
 libdevcore/picosha2.h:219: *(first++) = detail::mask_8bit(static_cast<uint8_t>((*iter >> (24-8*i))));

Please check that your changes are working as intended.

stackenbotten · 2019-05-06T12:54:45Z

There was an error when running test_check_style for commit 75d52633e0467333c488aa5fefe882105064f74b:

Coding style error:
 libdevcore/picosha2.h:219: *(first++) = detail::mask_8bit(static_cast<uint8_t>((*iter >> (24-8*i))));

Please check that your changes are working as intended.

chriseth · 2019-05-07T08:01:39Z

libsolidity/interface/CompilerStack.cpp

+{
+	if (ipfsUrlCached.empty())
+		if (scanner->source().size() < 1025 * 256)
+			ipfsUrlCached = "ipfs://" + dev::ipfsHashBase58(scanner->source());


We should decide which URL format to use. The IPFS project seems to prefer /ipfs/<hash>, but I don't think this is usable here because we just have a list of URLs instead of a key-value mapping. I have seen ipfs://ipfs/<hash>, but I'm not sure what the consensus is inside the ipfs project. @axic do you know more here?

ipfs/kubo#1678 (comment)

The canonical way seems to be /ipfs/hash/path, where compatibility versions exist, for example ipfs:/ipfs/hash/path

They say use this everywhere you can!

See below (there are 2 years between the two comments...)

chriseth · 2019-05-14T09:53:57Z

libsolidity/interface/CompilerStack.cpp

+{
+	if (ipfsUrlCached.empty())
+		if (scanner->source().size() < 1025 * 256)
+			ipfsUrlCached = "dweb:/ipfs/" + dev::ipfsHashBase58(scanner->source());


I believe this is the recommended way to denote IPFS URIs as per ipfs/specs#152 (comment)

It depends on which "upgrade stage" we want to be ;)

We cannot use /ipfs because we need a scheme, and I think we can afford not using ipfs:// because this is just a json artefact and not a website.

leonardoalt · 2019-05-14T14:37:32Z

libsolidity/interface/CompilerStack.cpp

+string const& CompilerStack::Source::ipfsUrl() const
+{
+	if (ipfsUrlCached.empty())
+		if (scanner->source().size() < 1025 * 256)


test/libdevcore/IpfsHash.cpp

chriseth commented Apr 25, 2019

View reviewed changes

libdevcore/picosha2.h

@@ -0,0 +1,360 @@

/*

Copy link

Contributor Author

chriseth Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was already part of this repository at some point :)

chriseth force-pushed the ipfsHash branch from 47cae3e to 7ced487 Compare April 25, 2019 18:02

chriseth force-pushed the ipfsHash branch from 7ced487 to 00af3ac Compare April 25, 2019 18:17

chriseth force-pushed the ipfsHash branch from 00af3ac to c009830 Compare April 29, 2019 21:03

chriseth force-pushed the ipfsHash branch from c009830 to bebee0c Compare April 30, 2019 09:26

chriseth force-pushed the ipfsHash branch from bebee0c to c31e19f Compare May 6, 2019 12:45

chriseth changed the title ~~[WIP] Tools to compute UnixFS IPFS hash.~~ Add IPFS hash of source files to metadata. May 6, 2019

chriseth marked this pull request as ready for review May 6, 2019 12:50

chriseth force-pushed the ipfsHash branch from c31e19f to 75d5263 Compare May 6, 2019 12:54

chriseth force-pushed the ipfsHash branch from 75d5263 to c517371 Compare May 6, 2019 13:12

chriseth commented May 7, 2019

View reviewed changes

Tools to compute UnixFS IPFS hash.

d753fcd

chriseth force-pushed the ipfsHash branch from c517371 to 74de38f Compare May 14, 2019 09:53

chriseth commented May 14, 2019

View reviewed changes

leonardoalt reviewed May 14, 2019

View reviewed changes

test/libdevcore/IpfsHash.cpp Show resolved Hide resolved

Use IPFS url in metadata for source links.

b01a8c5

chriseth force-pushed the ipfsHash branch from 74de38f to b01a8c5 Compare May 15, 2019 10:40

leonardoalt approved these changes May 15, 2019

View reviewed changes

chriseth merged commit ce19e2e into develop May 15, 2019

chriseth mentioned this pull request May 15, 2019

Changelog entry for adding ipfs links to metadata. #6768

Merged

leonardoalt deleted the ipfsHash branch August 9, 2019 09:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add IPFS hash of source files to metadata. #6599

Add IPFS hash of source files to metadata. #6599

chriseth commented Apr 25, 2019

chriseth Apr 25, 2019

stackenbotten commented Apr 25, 2019

stackenbotten commented Apr 25, 2019

axic commented Apr 25, 2019

chriseth commented Apr 25, 2019

codecov bot commented Apr 29, 2019 •

edited

Loading

stackenbotten commented Apr 29, 2019

stackenbotten commented Apr 30, 2019

stackenbotten commented May 6, 2019

stackenbotten commented May 6, 2019

chriseth May 7, 2019

leonardoalt May 14, 2019 •

edited

Loading

chriseth May 14, 2019

chriseth May 14, 2019

leonardoalt May 14, 2019

chriseth May 14, 2019

leonardoalt May 14, 2019

leonardoalt May 14, 2019

chriseth May 15, 2019

Add IPFS hash of source files to metadata. #6599

Add IPFS hash of source files to metadata. #6599

Conversation

chriseth commented Apr 25, 2019

Choose a reason for hiding this comment

stackenbotten commented Apr 25, 2019

stackenbotten commented Apr 25, 2019

axic commented Apr 25, 2019

chriseth commented Apr 25, 2019

codecov bot commented Apr 29, 2019 • edited Loading

Codecov Report

stackenbotten commented Apr 29, 2019

stackenbotten commented Apr 30, 2019

stackenbotten commented May 6, 2019

stackenbotten commented May 6, 2019

Choose a reason for hiding this comment

leonardoalt May 14, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Apr 29, 2019 •

edited

Loading

leonardoalt May 14, 2019 •

edited

Loading