Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extracted semantics tests to run with and without yul. #6916

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

ekpyron
Copy link
Member

@ekpyron ekpyron commented Jun 6, 2019

The need for this came up in #6888 and #6909.
This is a quick and dirty solution which we can approve upon later, but which will allow us to continue with #6888 soon.

@codecov

This comment has been minimized.

@ekpyron
Copy link
Member Author

ekpyron commented Jun 6, 2019

This let's us define compileViaYul: also, which lets the test be run with and without yul.

It's first run without yul as usual. In case of expectation mismatch isoltest will do the same as always and print an additional warning stating that the test has to pass via yul as well.
In case without yul passes, the test is re-run with yul. If that passes, everything's fine. If that fails, isoltest can update expectations as usual, but prints the additional error message stating that the same test did pass without yul.

@ekpyron ekpyron merged commit a4087d4 into develop Jun 6, 2019
@ekpyron ekpyron deleted the alsoViaYul branch June 6, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants