Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow underscores in hex strings. #7374

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Allow underscores in hex strings. #7374

merged 1 commit into from
Sep 9, 2019

Conversation

ekpyron
Copy link
Member

@ekpyron ekpyron commented Sep 6, 2019

Fixes #7290

chriseth
chriseth reviewed Sep 6, 2019
View reviewed changes
docs/types/value-types.rst Outdated Show resolved Hide resolved
chriseth
chriseth reviewed Sep 6, 2019
View reviewed changes
test/libsolidity/syntaxTests/literals/hex_string_misaligned_underscore.sol Outdated
}
}
// ----
// ParserError: (52-56): Expected even number of hex-nibbles within double-quotes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message is misleading - the number of nibbles is even.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better now? It wasn't triggered on missing quotes anyways... and that part was actually even wrong, since single quotes are valid as well...

@ekpyron ekpyron force-pushed the hexStringUnderscores branch from e55b89f to 2373001 Compare September 6, 2019 14:20
@leonardoalt
Copy link
Member

Test failing

@ekpyron
Copy link
Member Author

ekpyron commented Sep 6, 2019 •
edited
Loading

Test failing

That's a lie :-).

EDIT: [maybe we should really disable the solhint test to avoid this kind of confusion]

@ekpyron ekpyron force-pushed the hexStringUnderscores branch from 2373001 to 8e913eb Compare September 6, 2019 15:50
@ekpyron ekpyron requested a review from chriseth September 6, 2019 15:50
@ekpyron ekpyron force-pushed the hexStringUnderscores branch 3 times, most recently from 8e913eb to 39325b8 Compare September 6, 2019 15:58
@ekpyron ekpyron force-pushed the hexStringUnderscores branch from 39325b8 to 6f3341a Compare September 6, 2019 15:58
@chriseth chriseth merged commit a272506 into develop_060 Sep 9, 2019
@chriseth chriseth deleted the hexStringUnderscores branch September 9, 2019 09:48
@ekpyron ekpyron mentioned this pull request Sep 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriseth chriseth chriseth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekpyron @leonardoalt @chriseth