Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve from and unsafe as keywords #7955

Closed
wants to merge 1 commit into from
Closed

Reserve from and unsafe as keywords #7955

wants to merge 1 commit into from

Conversation

axic
Copy link
Member

@axic axic commented Dec 10, 2019

And also update documentation/chanelog with all the new keywords.

@axic
Copy link
Member Author

axic commented Dec 10, 2019

I would like to actually revive #6040 and reserve copy too.

@axic
Copy link
Member Author

axic commented Dec 10, 2019

Will move the keyword fixes (and not the new additions) from here to #7954.

@chriseth
Copy link
Contributor

Didn't we say unchecked instead of unsafe?

@chriseth
Copy link
Contributor

Do we really want to reserve them? Reserving them would only make sense if we intend to make kind-of-breaking changes as non-breaking.

@axic
Copy link
Member Author

axic commented Dec 10, 2019

Didn't we say unchecked instead of unsafe?

Yes, we ended up with unchecked, but for a while thought unsafe could be useful.

Do we really want to reserve them? Reserving them would only make sense if we intend to make kind-of-breaking changes as non-breaking.

I hope we can implement #1687 before the next breaking release, that's the motivation for from.

@axic
Copy link
Member Author

axic commented Dec 11, 2019

Should also consider ascii from #5167.

@axic
Copy link
Member Author

axic commented Dec 11, 2019

  • from is not needed, because it too common of a word, and the import parser already implements it as parsing a literal
  • unsafe has no clear use yet compared to unchecked
  • copy is part of a very early discussion (and not the factory syntax I thought it was)
  • ascii/unicode is planned for 0.7.0

@axic axic closed this Dec 11, 2019
@axic axic deleted the keywords branch December 11, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants