-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new
with CREATE2 and function call options
#8177
Conversation
40b8286
to
9014960
Compare
docs/control-structures.rst
Outdated
arguments. | ||
|
||
In particular, the counter ("nonce") is not used. This allows for more flexibility | ||
in creating contracts and in particular, you are able to deriven the address of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deriven
-> derive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are repeating in particular
here very near each other
new
with CREATE2new
with CREATE2 and function call options
ca9f0ff
to
92d808e
Compare
1c783dc
to
844c924
Compare
Amazing work guys! |
Are there any plans to add support for calculating contract addresses? |
There was a discussion #2136 (comment), but I think we forgot to follow up on it. |
Created #8798 for this. |
Missing:
fn{value:123, gas:43}()
syntax or an "not yet implemented" errorf{value: 0, value: 0}
), nor by applying the options set twice (f{value: 0}{value: 0}
))Problems:
We want to parse
but this also matches
i was able to work around this, checkout the last commit (parser hack).
However this hack still has a weakness. It can't parse
that is, if fn returns a function and we want to call that function with call options again, it will error (but only in the try/catch case)
I can maybe hack-fix that as well, but it will be even uglier.
I am open to alternative solutions.