Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow virtual and override for constructors. #8675

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Disallow virtual and override for constructors. #8675

merged 1 commit into from
Apr 15, 2020

Conversation

ekpyron
Copy link
Member

@ekpyron ekpyron commented Apr 15, 2020

Came up in chat in a dicussion with @yann300

chriseth
chriseth approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@chriseth chriseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened before? Was it just ignored?

@ekpyron
Copy link
Member Author

ekpyron commented Apr 15, 2020

What happened before? Was it just ignored?

I haven't actually checked in detail, but yes: I'm pretty sure it was just ignored. Not sure what effect virtual could have and after an override it still complained about the contract having to be abstract due to missing base constructor arguments, so also ignored.

@ekpyron ekpyron merged commit 10879bc into develop Apr 15, 2020
@ekpyron ekpyron deleted the disallowOverrideVirtualConstructor branch April 15, 2020 14:04
@Xanewok Xanewok mentioned this pull request Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriseth chriseth chriseth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekpyron @chriseth