Fix etherscan instances test after server modularity refactoring #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added a tsc linting step to catch this problem earlier in the future. |
kuzdogan
approved these changes
Sep 26, 2024
|
Problem is that it runs the build before linting now, and some tools are not configured to ignore dist folder. Will fix it |
|
How do the changes now check the tests .ts files but don't build them? With the changes in |
|
You can configure tsc to compile but not save the output with |
|
Should be fixed now |
kuzdogan
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1637 introduced changes which we didn't incorporate into the etherscan instances tests.