Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eth2 rebrand #441

Merged
merged 19 commits into from
Jan 25, 2022
Merged

Eth2 rebrand #441

merged 19 commits into from
Jan 25, 2022

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Jan 15, 2022

Description

Revamp site usage of 'Eth1' and 'Eth2' terminology in preparation for the merge.
This extends the PR in progress on the ethereum.org repo PR #4915 to cover the entire staking launchpad

Note: this will set back translation progress, as any strings that changed will no longer show up in their translated language, but will fall back to English version.

@wackerow wackerow requested a review from samajammin January 15, 2022 00:03
@samajammin
Copy link
Member

Nice! I'll review this week when able.

@wackerow did you check out this PR? #428

Hoping we can make incorporate / build off all the hard work @hwwhww put into that.

@wackerow wackerow changed the base branch from dev to renaming January 19, 2022 22:58
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!
I think it's good to remove the PoW context.

src/pages/SelectClient/index.tsx Outdated Show resolved Hide resolved
src/pages/SelectClient/index.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants