-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epic: Merge prep [#480] #493
Conversation
copy updates
Implemented on CL client pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick scan review. Generally looks great! 👍
Adding a "do not merge" label for now so that we merge it at the right time.
styling tweak
src/pages/MergeReadiness/index.tsx
Outdated
<Link primary inline to="https://nimbus.guide/"> | ||
Nimbus: The Nimbus book | ||
</Link> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a had time finding a specific reference for setting the fee recipient on Nimbus. I linked out to their main guide, but I was unable to find information on this within the guide, so open to suggestions from others on a better link here.
and expand intl support
also, abc order for clients
Layout adjustments and copy additions based on design suggestions.
Had a chat with @nloureiro who made a few suggestions including adding a navigation section at the top similar to the existing Checklist page. Just pushed those changes. |
I just saw it. I think it improved the page. Great work! |
Screen.Recording.2022-06-02.at.10.57.00.movone small bug > can you leave the link with the bold and change the opacity or the colour on :hover? to not make the text move when the mouse goes hover the link |
@nloureiro This uses the same global styles as the rest of the page. Don't disagree with you though that we should correct this, but it affects the entire site and is a separate issue. I can open an issue and take care of this separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I have pulled this PR in, but for anyone else laying eyes on this, please don't hesitate to still review it and @ me with any corrections you may see. Thanks! 🙏 |
Description
Updates content of Launchpad with several changes to prepare for the upcoming Merge upgrade.
Notably
/geth
), are listed in AppBar, and cards added to EL section of ChecklistRelated issue
#480
Preview homepage: https://deploy-preview-493--serene-carson-3331d5.netlify.app/en/
Merge readiness preview: https://deploy-preview-493--serene-carson-3331d5.netlify.app/en/merge-readiness