Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Merge prep [#480] #493

Merged
merged 30 commits into from
Jun 8, 2022
Merged

Epic: Merge prep [#480] #493

merged 30 commits into from
Jun 8, 2022

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented May 26, 2022

Description

Updates content of Launchpad with several changes to prepare for the upcoming Merge upgrade.

Notably

  • Adds a Merge Readiness Checklist page for stakers to review key information
  • Adds notification banner at top of homepage and PageContext pages to notify users with a link to the above checklist
  • Adds notifications to client pages that specifically call out the need to run both EL and CL clients
  • Adds and updates some related FAQ items
  • Adds EL client pages to have parity with CL clients pages, but having explicit url routes (ie. /geth), are listed in AppBar, and cards added to EL section of Checklist
  • Checklist updated to include more emphasis on EL clients

Related issue

#480

Preview homepage: https://deploy-preview-493--serene-carson-3331d5.netlify.app/en/
Merge readiness preview: https://deploy-preview-493--serene-carson-3331d5.netlify.app/en/merge-readiness

@wackerow wackerow changed the title Merge prep Epic: Merge prep [Fixes #480] May 27, 2022
@wackerow wackerow changed the title Epic: Merge prep [Fixes #480] Epic: Merge prep [Related to #480] May 27, 2022
@wackerow wackerow changed the title Epic: Merge prep [Related to #480] Epic: Merge prep [#480] May 27, 2022
@wackerow wackerow marked this pull request as ready for review May 27, 2022 02:43
@wackerow wackerow requested review from CarlBeek and djrtwo May 27, 2022 02:53
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick scan review. Generally looks great! 👍

Adding a "do not merge" label for now so that we merge it at the right time.

src/Routes.tsx Outdated Show resolved Hide resolved
src/components/AppBar.tsx Outdated Show resolved Hide resolved
src/pages/MergeReadiness/index.tsx Outdated Show resolved Hide resolved
src/pages/MergeReadiness/index.tsx Outdated Show resolved Hide resolved
src/pages/MergeReadiness/index.tsx Outdated Show resolved Hide resolved
Comment on lines 165 to 167
<Link primary inline to="https://nimbus.guide/">
Nimbus: The Nimbus book
</Link>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a had time finding a specific reference for setting the fee recipient on Nimbus. I linked out to their main guide, but I was unable to find information on this within the guide, so open to suggestions from others on a better link here.

wackerow added 4 commits May 31, 2022 15:45
and expand intl support
Include all links that include the route name, allowing it to also catch hash header links
also, abc order for clients
Layout adjustments and copy additions based on design suggestions.
@wackerow
Copy link
Member Author

wackerow commented Jun 1, 2022

Had a chat with @nloureiro who made a few suggestions including adding a navigation section at the top similar to the existing Checklist page. Just pushed those changes.

@nloureiro
Copy link

Had a chat with @nloureiro who made a few suggestions including adding a navigation section at the top similar to the existing Checklist page. Just pushed those changes.

I just saw it. I think it improved the page. Great work!

@nloureiro
Copy link

Screen.Recording.2022-06-02.at.10.57.00.mov

one small bug > can you leave the link with the bold and change the opacity or the colour on :hover? to not make the text move when the mouse goes hover the link

@wackerow
Copy link
Member Author

wackerow commented Jun 2, 2022

@nloureiro This uses the same global styles as the rest of the page. Don't disagree with you though that we should correct this, but it affects the entire site and is a separate issue. I can open an issue and take care of this separately.

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wackerow
Copy link
Member Author

wackerow commented Jun 7, 2022

@hwwhww @CarlBeek Think this is ready, just wanted to ping once more in case you'd like to add anything more here. Would like to pull this in today if possible =)

@wackerow wackerow merged commit b65c9e3 into dev Jun 8, 2022
@wackerow
Copy link
Member Author

wackerow commented Jun 8, 2022

I have pulled this PR in, but for anyone else laying eyes on this, please don't hesitate to still review it and @ me with any corrections you may see. Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants