Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top-up modal escape [Fixes #383] #495

Merged
merged 7 commits into from
Jun 6, 2022
Merged

Add top-up modal escape [Fixes #383] #495

merged 7 commits into from
Jun 6, 2022

Conversation

wackerow
Copy link
Member

Description

  • Adds closing X to modal pop-up on /top-up page
  • Adds "Connect wallet" button to same page if user has not connected, and has exited the modal

Related issue

[Fixes #383]

@hwwhww
Copy link
Contributor

hwwhww commented May 27, 2022

Just commenting on the preview page, it looks great! 👍

Defer to @samajammin on the TypeScript magic.

@wackerow wackerow requested a review from samajammin May 27, 2022 20:15
Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @wackerow!

This may have already been an issue (i.e. unrelated from your PR) but I noticed when I'm on a different network other than Mainnet (e.g. Arbitrum), it creates some funky behaviour when trying to connect (nothing happens when I click MetaMask). If I'm on Mainnet, it correctly tells me to switch to Goerli.

Mind making a change here to check if user is on ANY network other than the correct network? If so, we should display that modal to switch:
Screen Shot 2022-05-30 at 9 33 47 AM

If you'd like, feel free to create a separate issue for this... ideal logic here might be to auto-switch the network for MetaMask users.

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! left a couple of small suggestions, nothing blocking.

src/pages/TopUp/components/WalletConnectModal.tsx Outdated Show resolved Hide resolved
src/pages/TopUp/components/WalletConnectModal.tsx Outdated Show resolved Hide resolved
src/pages/TopUp/components/WalletConnectModal.tsx Outdated Show resolved Hide resolved
@wackerow
Copy link
Member Author

@samajammin Yeah this is another existing issue it looks like. Opened an issue for it, but gonna hold on building it into this PR. Can revisit separately.

@wackerow wackerow requested a review from samajammin May 31, 2022 20:54
@samajammin samajammin merged commit 44eba63 into dev Jun 6, 2022
@samajammin samajammin deleted the top-up-fix branch June 6, 2022 15:07
This was referenced Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top Up page modal has no escape
4 participants