Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract and re-use ClientDiversityWarning [Fixes #508] #512

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Extract and re-use ClientDiversityWarning [Fixes #508] #512

merged 1 commit into from
Jun 27, 2022

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Jun 21, 2022 •
edited
Loading

Description

  • Extracts the component being displayed on the Prysm page, and makes it more generalizable.
  • Allows passing "children" to the component to customize the message being displayed where it is used.
  • Adjusted copy for Prysm warning (no longer being used by true majority, but still more popular and over 33%)
  • Added component to Geth page with similar warning about being over 66%.
  • Added link to clientdiversity.org for users to check the latest numbers

Geth preview: https://deploy-preview-512--serene-carson-3331d5.netlify.app/en/geth

Related issue

@wackerow wackerow requested a review from hwwhww June 22, 2022 16:56
@wackerow wackerow changed the title Extract and reuse ClientDiversityWarning [Fixes #508] Extract and re-use ClientDiversityWarning [Fixes #508] Jun 22, 2022
samajammin
samajammin approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@samajammin samajammin merged commit 0a46a2e into dev Jun 27, 2022
@samajammin samajammin deleted the client-diversity-warning branch June 27, 2022 18:29
This was referenced Jun 30, 2022
Merged
Merged
@wackerow wackerow mentioned this pull request Oct 5, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samajammin samajammin samajammin approved these changes

@hwwhww hwwhww Awaiting requested review from hwwhww

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wackerow @samajammin