-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate MergeReadiness #557
Conversation
reduce to simple pipe-separated client list
reduce to simple pipe-separated client list
Added a few commits to clean up some of the links... original used the name of the document from each client docs page like "Configure Fee Recipient" but this ended up being redundant, and would just add to the number of strings that need to be translated. I removed these labels, pulled any client specific links into the clientInfo object, and render these links as just pipe-separated inline lists, adding some text in front of each to identify the type of doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! It's not just deprecating the merge checklist but also some thoughtful proofreading work. 👍
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
Co-Authored-By: Hsiao-Wei Wang <9263930+hwwhww@users.noreply.github.com>
Co-authored-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
Co-Authored-By: Hsiao-Wei Wang <9263930+hwwhww@users.noreply.github.com>
Description
Preview deploy:
https://deploy-preview-557--serene-carson-3331d5.netlify.app/en/checklist