Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate MergeReadiness #557

Merged
merged 13 commits into from
Sep 28, 2022
Merged

Deprecate MergeReadiness #557

merged 13 commits into from
Sep 28, 2022

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Sep 23, 2022

Description

  • Removes notifications related to The Merge
  • Removes MergeReadiness checklist page
  • Moves pertinent information from this page to corresponding places in the existing FAQ and Checklist pages
  • This includes information related to setting up a JWT and fee recipient
  • Adds client-diversity notice to Lighthouse page
  • Updates copy to be correct in a post-merge environment
  • Updates notes about Shanghai to inform that withdrawal functionality is proposed to be included in this upgrade. Removing stating inclusion as fact until further decisions have been made regarding this upgrade.

Preview deploy:
https://deploy-preview-557--serene-carson-3331d5.netlify.app/en/checklist

@wackerow wackerow marked this pull request as ready for review September 23, 2022 14:15
reduce to simple pipe-separated client list
reduce to simple pipe-separated client list
@wackerow
Copy link
Member Author

Added a few commits to clean up some of the links... original used the name of the document from each client docs page like "Configure Fee Recipient" but this ended up being redundant, and would just add to the number of strings that need to be translated.

I removed these labels, pulled any client specific links into the clientInfo object, and render these links as just pipe-separated inline lists, adding some text in front of each to identify the type of doc.

@wackerow wackerow assigned CarlBeek and unassigned CarlBeek Sep 27, 2022
@wackerow wackerow requested a review from CarlBeek September 27, 2022 19:26
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! It's not just deprecating the merge checklist but also some thoughtful proofreading work. 👍

src/pages/Landing/Upgrades/index.tsx Show resolved Hide resolved
src/pages/Landing/Upgrades/index.tsx Outdated Show resolved Hide resolved
src/pages/FAQ/index.jsx Outdated Show resolved Hide resolved
src/pages/Checklist/index.tsx Outdated Show resolved Hide resolved
src/pages/Checklist/index.tsx Outdated Show resolved Hide resolved
src/pages/Checklist/index.tsx Show resolved Hide resolved
src/pages/FAQ/index.jsx Outdated Show resolved Hide resolved
src/pages/FAQ/index.jsx Outdated Show resolved Hide resolved
wackerow and others added 4 commits September 28, 2022 16:49
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
Co-Authored-By: Hsiao-Wei Wang <9263930+hwwhww@users.noreply.github.com>
Co-authored-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
Co-Authored-By: Hsiao-Wei Wang <9263930+hwwhww@users.noreply.github.com>
@wackerow wackerow merged commit c27184d into dev Sep 28, 2022
@wackerow wackerow deleted the deprecate-readiness branch September 28, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants