Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests (Mark non returning functions) #1285

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Update tests (Mark non returning functions) #1285

merged 3 commits into from
Sep 13, 2023

Conversation

hugo-dc
Copy link
Member

@hugo-dc hugo-dc commented Aug 18, 2023

Depends on #1238

@hugo-dc hugo-dc marked this pull request as draft August 18, 2023 22:32
@zurdo88 zurdo88 mentioned this pull request Aug 19, 2023
Closed
@hugo-dc hugo-dc force-pushed the update-tests-nrf branch 2 times, most recently from 804e751 to e3cf761 Compare August 21, 2023 06:49
gumb0
gumb0 reviewed Aug 22, 2023
View reviewed changes
src/EIPTestsFiller/StateTests/stEOF/stEIP3540/EOF1_ExecutionFiller.yml Outdated
@@ -28,7 +27,7 @@ EOF1_Execution:
balance: 0
# Basic valid EOF code
# code section: ':yul { sstore(0, 1) stop() }'
code: ':raw 0xef000101000402000100060300000000000002600160005500'
code: ':raw 0xef000101000402000100060400000000000002600160005500'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file not updated yet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this file was not updated to change first code section output to non-returning function. It is interesting because, evmone is filling the test correctly... this means... it is executing this invalid code in pre-state. Currently there is a pre-state EOF code validation when running the tests, but there is not validation when filling the tests. I have updated the file and refilled the tests. Also submitted this PR in the evmone repo in order to validate eof code in pre-state when filling tests.

@hugo-dc hugo-dc force-pushed the update-tests-nrf branch 2 times, most recently from 6886b60 to ba5003c Compare August 23, 2023 14:33
@hugo-dc hugo-dc marked this pull request as ready for review September 6, 2023 15:11
qbzzt
qbzzt approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@qbzzt qbzzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If it runs OK, I think it's OK.

@winsvega
Copy link
Collaborator

is this :raw code generated by some script? no way to make it more readable?
you can split the code bytes in .yml format and add # comments after each line. it will merge into bytes in generated test.

@gumb0
Copy link
Member

gumb0 commented Sep 11, 2023

is this :raw code generated by some script? no way to make it more readable?

Which one are you referring to? There are often comments with assembly or pseudo-yul code corresponding to bytecode. But maybe not in Ori's tests...

@winsvega winsvega merged commit f3eb1be into ethereum:develop Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gumb0 gumb0 gumb0 left review comments

@qbzzt qbzzt qbzzt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugo-dc @winsvega @gumb0 @qbzzt