Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue #683 test STATICCALL violation in call to precompile #700

Merged
merged 6 commits into from
Jun 29, 2020
Merged

fix issue #683 test STATICCALL violation in call to precompile #700

merged 6 commits into from
Jun 29, 2020

Conversation

sr9000
Copy link
Contributor

@sr9000 sr9000 commented Jun 18, 2020

fix issue #683 test STATICCALL violation in call to precompile

  • staticcall from transaction
  • staticcall from called contract
  • staticcall from initialization contract code

@sr9000
fix issue ethereum#683
ca47be2 
test STATICCALL violation in call to precompile
- staticcall from transaction
- staticcall from called contract
- staticcall from initialization contract code
@sr9000
fix issue ethereum#683
dc42a00 
improve test coverage
@winsvega
Copy link
Collaborator

winsvega commented Jun 20, 2020 •
edited
Loading

excelent.

  • add comment section to the fillers with a description of whats happenning with what transaction in the test.
  "_info" : {
     "comment" : "Description"
}
  • commit --filltests results
  • add one more test with bytecode from issue 683
  • update PRLOG file in the tests repo

@winsvega winsvega self-requested a review June 20, 2020 21:14
@winsvega winsvega merged commit 547d866 into ethereum:develop Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winsvega winsvega winsvega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sr9000 @winsvega