Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay network pings from test harness are not pinging #147

Closed
njgheorghita opened this issue Oct 19, 2021 · 3 comments · Fixed by #155
Closed

Overlay network pings from test harness are not pinging #147

njgheorghita opened this issue Oct 19, 2021 · 3 comments · Fixed by #155

Comments

@njgheorghita
Copy link
Collaborator

Both pings to each overlay network from the test harness seem to be broken. Hopefully #141 will help with debugging the issue.
@njgheorghita njgheorghita mentioned this issue Oct 19, 2021
Merged
@lithp lithp self-assigned this Oct 22, 2021
@njgheorghita njgheorghita mentioned this issue Oct 25, 2021
Merged
lithp added a commit to lithp/trin that referenced this issue Oct 26, 2021
@lithp
fix ethereum#147 by adding support for skipping STUN
ad3490a
lithp added a commit to lithp/trin that referenced this issue Oct 26, 2021
@lithp
fix ethereum#147 by adding support for skipping STUN
21c9142
@lithp lithp removed their assignment Oct 26, 2021
@lithp
Copy link
Contributor

lithp commented Oct 26, 2021

Not one but two PRs exist to fix this, unassigning myself :)

@njgheorghita
Copy link
Collaborator Author

Ahhh sorry, didn't see you had assigned this!

@lithp
Copy link
Contributor

lithp commented Oct 26, 2021

Oh, no, I wasn't trying to say this had been sniped! Happy to see that it's being fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add internal ip cli flag njgheorghita/trin
2 participants
@lithp @njgheorghita