Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add deployment step to confirm that docker images can be run #1054

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

mrferris
Copy link
Collaborator

@mrferris mrferris commented Dec 1, 2023

What was wrong?

We had an issue where the docker image tagged for testnet couldn't be run, it was missing a library.

How was it fixed?

Adds a step to the CI that attempts to run the docker image (with the -h flag for immediate but successful exit).

Adds a step to release steps to check that the master CI was successful for what we're about to deploy. This both applies to the docker image, as well as to the testing iteself, which I realized was also failing for the latest commit on master after having deployed a broken docker image.

To-Do

@KolbyML
Copy link
Member

KolbyML commented Dec 1, 2023

@mike.ferris #1054

Are you sure -h does an immediate exit if successful? https://docs.docker.com/engine/reference/commandline/run/ says it is for specifying host name

@mrferris
Copy link
Collaborator Author

mrferris commented Dec 1, 2023

@mike.ferris #1054

Are you sure -h does an immediate exit if successful? https://docs.docker.com/engine/reference/commandline/run/ says it is for specifying host name

Sorry I should have been more specific, this is the shorthand --help flag being passed to trin so that it just gives the help output instead of starting the long running trin process.

Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how helpful this will be but if it does what it says it does it could save us

@mrferris mrferris merged commit d396806 into master Dec 1, 2023
5 checks passed
@mrferris mrferris deleted the safety-step branch December 1, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants