fix: add deployment step to confirm that docker images can be run #1054
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We had an issue where the docker image tagged for testnet couldn't be run, it was missing a library.
How was it fixed?
Adds a step to the CI that attempts to run the docker image (with the
-h
flag for immediate but successful exit).Adds a step to release steps to check that the master CI was successful for what we're about to deploy. This both applies to the docker image, as well as to the testing iteself, which I realized was also failing for the latest commit on master after having deployed a broken docker image.
To-Do