Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC test to show bug DOS vector exists Show 1 node accepting multiple streams for the same content #1056

Closed
wants to merge 1 commit into from

Conversation

KolbyML
Copy link
Member

@KolbyML KolbyML commented Dec 4, 2023

What was wrong?

How was it fixed?

To-Do

@njgheorghita
Copy link
Collaborator

Just a quick note that typically we've used [WIP] as the prefix in the pr name (rather than POC) to denote that a pr is a "work in progress" aka not ready for review.

@KolbyML
Copy link
Member Author

KolbyML commented Dec 6, 2023

The PR will never be ready for review, and it really isn't a work in process cause there is no work to progress. I used proof of concept because that is all this PR is a proof of concept.

@njgheorghita
Copy link
Collaborator

Sure, but I'm just recommending [WIP] since that's the conventional way we signal to each other that a pr can be effectively ignored for whatever reason

@KolbyML
Copy link
Member Author

KolbyML commented Dec 6, 2023

I thought that is what draft is for. This PR doesn't include WIP, but is marked as draft #1029

@KolbyML
Copy link
Member Author

KolbyML commented Oct 3, 2024

Closing this PR. We have implemented basic protection a while ago. This POC is unmaintained

@KolbyML KolbyML closed this Oct 3, 2024
@KolbyML KolbyML deleted the show-issue-to-mike branch January 22, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants