Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new history proof types and content value #1691

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

morph-dev
Copy link
Collaborator

@morph-dev morph-dev commented Feb 19, 2025

What was wrong?

We have to migrate to new encoding for HeaderWithProof and HistoryContentValue.
See #1666 for more details.

How was it fixed?

Type and db migration is already done in previous PRs.

Important things related to this PR:

  • updates the HistoryContentValue type that is re-exported in ethportal-api
    • HeaderWithProof is not re-exported, so we have to change imports
    • old types should no longer be used, except during db migration
  • Updates portal-spec-tests submodule to the latest commit (that contains updated test vectors)
  • Header validator is updated to use new types
  • Some state network tests will not be passing when header validation is re-enabled
    • This is caused by test vectors containing only header, without proof, and should be fixed by adding header proof
    • Affected tests (as fast I could find): state validator and state peer-to-peer

NOTE: The merge and release that contains this PR should be coordinated with other clients

@morph-dev morph-dev self-assigned this Feb 19, 2025
@morph-dev morph-dev marked this pull request as ready for review February 23, 2025 21:55
Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks good

Copy link
Member

@ogenev ogenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morph-dev morph-dev merged commit 5438dc9 into ethereum:master Feb 24, 2025
14 checks passed
@morph-dev morph-dev deleted the history_migration branch February 24, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants