This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Address ethereum/eth2.0-specs#673: make getting assignments more generic #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
changed the title
great way to review a spec PR! |
djrtwo
approved these changes
Feb 25, 2019
| @@ -368,9 +371,22 @@ def get_next_epoch_committee_assignment( | |||
| propose a beacon block at the assigned slot. | |||
| """ | |||
| current_epoch = state.current_epoch(config.SLOTS_PER_EPOCH) | |||
| previous_epoch = state.previous_epoch(config.SLOTS_PER_EPOCH, config.GENESIS_EPOCH) | |||
| next_epoch = current_epoch + 1 | |||
There was a problem hiding this comment.
Found a bug in the spec when I was reviewing your (correct) code
ethereum/consensus-specs#689
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
I updated this small fix during reviewing the spec PR. 😅
See spec PR: ethereum/consensus-specs#673
Pending on spec PR got merged.
How was it fixed?
Sync with the spec PR.
Now, this function can be used to get previous, current, or next epoch committee.
Cute Animal Picture
🐿