This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Rework ProposalSignedData to Proposal and signature refactoring
#355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 2, 2019
ralexstokes
suggested changes
Mar 6, 2019
There was a problem hiding this comment.
looks great! one minor change so that the validation error message is correct. (implicit here is that we will want to get rid of any hash and root properties once we move to the full SSZ but i believe there is already an issue to track this.... and all the TODOs we have been sprinkling across the code)
| SignatureDomain.DOMAIN_PROPOSAL, | ||
| ) | ||
| ) | ||
| if not proposal_signature_is_valid: | ||
| raise ValidationError( | ||
| "Proposal signature is invalid: " | ||
| f"proposer pubkey: {pubkey}, message_hash: {proposal_signed_data.root}, " | ||
| f"signature: {proposal_signature}" | ||
| f"proposer pubkey: {pubkey}, message_hash: {proposal.root}, " |
There was a problem hiding this comment.
s/proposal.root/proposal.signed_root/ correct?
…oposal_signature_2` into per `Proposal`'s `signature`
ralexstokes
approved these changes
Mar 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
#343 task 2: rework
ProposalSignedDatatoProposalSpec PR: ethereum/consensus-specs#633
How was it fixed?
ProposalSignedDatatoProposalProposerSlashing.proposal_signature_1andProposerSlashing.proposal_signature_2into perProposal'ssignaturesigned_rootcurrently, I add an propertyProposal. signed_rootas the replacement interface.Cute Animal Picture