This repository was archived by the owner on Jul 1, 2021. It is now read-only.
Remove unused CancelToken from MemoryTransport #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
force-pushed
the
piper/remove-unneeded-token-from-MemoryTransport
branch
from
89cadcb to
0d00dd6
Compare
pipermerriam
force-pushed
the
piper/remove-unneeded-token-from-MemoryTransport
branch
from
0d00dd6 to
aa54a13
Compare
pipermerriam
force-pushed
the
piper/remove-unneeded-token-from-MemoryTransport
branch
from
aa54a13 to
15a6d68
Compare
|
Includes #839 to fix the flaky test. |
carver
approved these changes
Jul 25, 2019
|
Nice |
pipermerriam
deleted the
piper/remove-unneeded-token-from-MemoryTransport
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The
MemoryTransportaccepted aCancelTokenas part of the constructor but it never actually uses it.How was it fixed?
Removed it.
To-Do
Cute Animal Picture