Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dissallow python 3.5.1 #1094

Closed
pipermerriam opened this issue Oct 8, 2018 · 5 comments
Closed

Dissallow python 3.5.1 #1094

pipermerriam opened this issue Oct 8, 2018 · 5 comments
Labels
Good First Issue

Comments

@pipermerriam
Copy link
Member

What was wrong?

It looks like typing.NewType may not be available in python 3.5.1

#1091

How can it be fixed?

Check what version NewType was added and restrict our python versions as declared in setup.py to be >= that version
andrzej3393 added a commit to andrzej3393/web3.py that referenced this issue Oct 8, 2018
@andrzej3393
Python version bump.
4fb46fb 
According to https://docs.python.org/3/library/typing.html#typing.NewType `NewType` was introduced in Python 3.5.2.
Fixes ethereum#1094
@andrzej3393 andrzej3393 mentioned this issue Oct 8, 2018
Merged
@pipermerriam
Copy link
Member Author

Fixed by #1095

@carver
Copy link
Collaborator

carver commented Oct 9, 2018

Reminder to backport to v4

@carver carver reopened this Oct 9, 2018
@carver
Copy link
Collaborator

carver commented Oct 9, 2018 •
edited
Loading

Also, because of #1012 (comment) maybe we should require >=3.5.3

@pipermerriam pipermerriam mentioned this issue Oct 9, 2018
Closed
@pipermerriam
Copy link
Member Author

#1096

This was referenced Oct 16, 2018
Merged
Merged
@stefanmendoza
Copy link
Contributor

@pipermerriam I think this can be closed with the two PRs above. 👍

kclowes pushed a commit to pjryan93/web3.py that referenced this issue Apr 25, 2019
@andrzej3393 @kclowes
Python version bump.
a2a7cbf 
According to https://docs.python.org/3/library/typing.html#typing.NewType `NewType` was introduced in Python 3.5.2.
Fixes ethereum#1094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@carver @pipermerriam @stefanmendoza